Repository navigation
fix: restore current JS and Wasm GC emulator builds - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current toolchain rejects the root JSON module manifest and the package's redundant
UInt32 = UIntalias, since UInt32 is now a built-in type. Migrate the manifest and use the equivalent built-in type. Update browser asset paths fromtargetto_buildso the documented release builds can actually be loaded.CI now exercises both JS and Wasm GC exports with the bundled nestest ROM and compares all 8,991 instruction addresses, CPU registers, and PPU/CPU cycle counters with the reference log. Both backends pass locally. Disassembly text is deliberately outside this state oracle: the emulator uses ISC rather than ISB spelling and has five pre-existing APU read-value differences near the end of the trace, already noted in its source. No reference trace or emulation implementation is changed.
This repairs the documented JS and Wasm GC targets only. Raw Wasm still fails on
$moonbit.free; existing PR4's allocator change needs separate ownership validation and is left untouched. Eight existing deprecation warnings remain. No publication or claim of complete raw Wasm compatibility is included.